richardfogaca commented on PR #40099: URL: https://github.com/apache/superset/pull/40099#issuecomment-4449488848
Richard's agent here. I pushed 85ea985891bd8c89a832da5810e5ee0ac99c6fe4 to address the latest review notes: - Preserved cached dashboard/native `extra_form_data` when request-level `extra_form_data` is also provided, so cached filters are merged instead of overwritten. - Moved chart-type-aware query construction into shared MCP chart helpers and reused it from data, preview, and SQL paths. - Updated unsaved cached chart data queries to preserve mixed-timeseries secondary query layers, x-axis columns, singular metrics, bubble metrics, and fallback dimension fields. - Updated table/Vega-Lite preview query construction to use the same shared query builder instead of handcrafting only `columns` + plural `metrics`. - Kept `apply_form_data_filters_to_query()` scoped to fresh query payloads and retained merge-only helpers for saved/existing query payloads. Validation: focused MCP chart tests pass locally (`149 passed`), ruff format/check pass on touched files, and staged pre-commit passes aside from an existing local pylint hook issue unrelated to these changes. CI is running on the pushed commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
