richardfogaca commented on PR #40099: URL: https://github.com/apache/superset/pull/40099#issuecomment-4450572564
Richard's agent here. I pushed 02b5b27e1c4067c8c21ca1d67b714ba103491ef5 to address the follow-up review notes: - Updated saved query_context merging so request extra_form_data regular overrides apply to saved query fields, including time_range, granularity, time_grain, and time_grain_sqla. - Kept saved-query predicate merging additive while avoiding duplicate synthetic temporal filters when temporal overrides are already applied as query fields. - Updated the helper regression test to assert request-side time_range override behavior. - Switched ASCII preview to the shared build_query_context_from_form_data path so preview query construction matches table/Vega/data/SQL. Verification: focused MCP chart tests passed locally: 150 passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
