codeant-ai-for-open-source[bot] commented on code in PR #40120: URL: https://github.com/apache/superset/pull/40120#discussion_r3241983485
########## superset/extensions/middleware.py: ########## @@ -0,0 +1,69 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import re +from collections.abc import Callable, Iterator +from typing import Any + +# Matches /api/v1/extensions/<publisher>/<name>/<file> +_EXTENSION_ASSET_RE = re.compile(r"^/api/v1/extensions/[^/]+/[^/]+/[^/]+$") + + +class ExtensionStaticCacheMiddleware: + """ + Strips the `Vary: Cookie` header from extension static asset responses. + + Flask's session machinery adds `Vary: Cookie` to every response whenever + the session object is accessed anywhere in the request pipeline, even by + unrelated `after_request` hooks. This prevents browsers from caching + extension chunks (JS, WASM) by URL. + + Extension asset filenames include a content hash, so the URL is the only + cache key needed. This middleware removes `Vary: Cookie` for those URLs + after the full WSGI response has been assembled, after all Flask hooks have + run. + """ + + def __init__(self, app: Any) -> None: + self.app = app + + def __call__( + self, environ: dict[str, Any], start_response: Callable[..., Any] + ) -> Iterator[bytes]: + path = environ.get("PATH_INFO", "") + if not _EXTENSION_ASSET_RE.match(path): + return self.app(environ, start_response) Review Comment: **🟠Architect Review — HIGH** ExtensionStaticCacheMiddleware matches PATH_INFO against a hard-coded "^/api/v1/extensions/…" pattern but is wrapped outside AppRootMiddleware, so in deployments using APPLICATION_ROOT/SUPERSET_APP_ROOT PATH_INFO still includes the prefix (e.g. "/superset/api/v1/extensions/..."), the regex never matches, and Vary: Cookie is not stripped from extension asset responses. **Suggestion:** Normalize the request path before matching (for example, strip SCRIPT_NAME/app-root from PATH_INFO or match on the suffix) so extension asset URLs are detected in rooted deployments, and add integration coverage with AppRootMiddleware enabled to verify Vary: Cookie is removed. [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20an%20%2A%2AArchitect%20%2F%20Logical%20Review%2A%2A%20comment%20left%20during%20a%20code%20review.%20These%20reviews%20are%20first-class%2C%20important%20findings%20%E2%80%94%20not%20optional%20suggestions.%20Do%20NOT%20dismiss%20this%20as%20a%20%27big%20architectural%20change%27%20just%20because%20the%20title%20says%20architect%20review%3B%20most%20of%20these%20can%20be%20resolved%20with%20a%20small%2C%20localized%20fix%20once%20the%20intent%20is%20understood.%0A%0A%2A%2APath%3A%2A%2A%20superset%2Fextensions%2Fmiddleware.py%0A%2A%2ALine%3A%2A%2A%2046%3A48%0A%2A%2AComment%3A%2A%2A%0A%09%2AHIGH%3A%20ExtensionStaticCacheMiddleware%20matches%20PATH_INFO%20against%20a%20hard-coded%20%22%5E%2Fapi%2Fv1%2Fextensions%2F%E2%80%A6%22%20pattern%20but%20is%20wrapped%20outside%20AppRootMiddleware%2C%20so%20in%20deployments%20using%20APPLICATION_ROOT%2FSUPERSET_APP_ROOT%20PATH_INFO%20still%20includes%20the%20prefix %20%28e.g.%20%22%2Fsuperset%2Fapi%2Fv1%2Fextensions%2F...%22%29%2C%20the%20regex%20never%20matches%2C%20and%20Vary%3A%20Cookie%20is%20not%20stripped%20from%20extension%20asset%20responses.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AIf%20a%20suggested%20approach%20is%20provided%20above%2C%20use%20it%20as%20the%20authoritative%20instruction.%20If%20no%20explicit%20code%20suggestion%20is%20given%2C%20you%20MUST%20still%20draft%20and%20apply%20your%20own%20minimal%2C%20localized%20fix%20%E2%80%94%20do%20not%20punt%20back%20with%20%27no%20suggestion%20provided%2C%20review%20manually%27.%20Keep%20the%20change%20as%20small%20as%20possible%3A%20add%20a%20guard%20clause%2C%20gate%20on%20a%20loading%20state%2C%20reorder%20an%20await%2C%20wrap%20in%20a%20conditional%2C%20etc.%20Do%20not%20refactor%20surrounding%20code%20or%20expan d%20scope%20beyond%20the%20finding.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20an%20%2A%2AArchitect%20%2F%20Logical%20Review%2A%2A%20comment%20left%20during%20a%20code%20review.%20These%20reviews%20are%20first-class%2C%20important%20findings%20%E2%80%94%20not%20optional%20suggestions.%20Do%20NOT%20dismiss%20this%20as%20a%20%27big%20architectural%20change%27%20just%20because%20the%20title%20says%20architect%20review%3B%20most%20of%20these%20can%20be%20resolved%20with%20a%20small%2C%20localized%20fix%20once%20the%20intent%20is%20understood.%0A%0A%2A%2APath%3A%2A%2A%20superset%2Fextensions%2Fmiddleware.py%0A %2A%2ALine%3A%2A%2A%2046%3A48%0A%2A%2AComment%3A%2A%2A%0A%09%2AHIGH%3A%20ExtensionStaticCacheMiddleware%20matches%20PATH_INFO%20against%20a%20hard-coded%20%22%5E%2Fapi%2Fv1%2Fextensions%2F%E2%80%A6%22%20pattern%20but%20is%20wrapped%20outside%20AppRootMiddleware%2C%20so%20in%20deployments%20using%20APPLICATION_ROOT%2FSUPERSET_APP_ROOT%20PATH_INFO%20still%20includes%20the%20prefix%20%28e.g.%20%22%2Fsuperset%2Fapi%2Fv1%2Fextensions%2F...%22%29%2C%20the%20regex%20never%20matches%2C%20and%20Vary%3A%20Cookie%20is%20not%20stripped%20from%20extension%20asset%20responses.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AIf%20a%20suggested%20approach%20is%20provided%20above%2C%20use%20it%20as%20the%20authoritative%20instruction.%20If%20no%20explicit%20code%20suggestion%20is%20given%2C%20you%20MUST%20still%20draft%20and%20apply%20your%2 0own%20minimal%2C%20localized%20fix%20%E2%80%94%20do%20not%20punt%20back%20with%20%27no%20suggestion%20provided%2C%20review%20manually%27.%20Keep%20the%20change%20as%20small%20as%20possible%3A%20add%20a%20guard%20clause%2C%20gate%20on%20a%20loading%20state%2C%20reorder%20an%20await%2C%20wrap%20in%20a%20conditional%2C%20etc.%20Do%20not%20refactor%20surrounding%20code%20or%20expand%20scope%20beyond%20the%20finding.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is an **Architect / Logical Review** comment left during a code review. These reviews are first-class, important findings — not optional suggestions. Do NOT dismiss this as a 'big architectural change' just because the title says architect review; most of these can be resolved with a small, localized fix once the intent is understood. **Path:** superset/extensions/middleware.py **Line:** 46:48 **Comment:** *HIGH: ExtensionStaticCacheMiddleware matches PATH_INFO against a hard-coded "^/api/v1/extensions/…" pattern but is wrapped outside AppRootMiddleware, so in deployments using APPLICATION_ROOT/SUPERSET_APP_ROOT PATH_INFO still includes the prefix (e.g. "/superset/api/v1/extensions/..."), the regex never matches, and Vary: Cookie is not stripped from extension asset responses. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. If a suggested approach is provided above, use it as the authoritative instruction. If no explicit code suggestion is given, you MUST still draft and apply your own minimal, localized fix — do not punt back with 'no suggestion provided, review manually'. Keep the change as small as possible: add a guard clause, gate on a loading state, reorder an await, wrap in a conditional, etc. Do not refactor surrounding code or expand scope beyond the finding. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
