bito-code-review[bot] commented on code in PR #40120:
URL: https://github.com/apache/superset/pull/40120#discussion_r3247073466
##########
superset-frontend/src/extensions/ExtensionsStartup.tsx:
##########
@@ -82,17 +82,7 @@ const ExtensionsStartup: React.FC<{ children?:
React.ReactNode }> = ({
const setup = async () => {
if (isFeatureEnabled(FeatureFlag.EnableExtensions)) {
- try {
- await ExtensionsLoader.getInstance().initializeExtensions();
- supersetCore.utils.logging.info(
- 'Extensions initialized successfully.',
- );
- } catch (error) {
- supersetCore.utils.logging.error(
- 'Error setting up extensions:',
- error,
- );
- }
+ await ExtensionsLoader.getInstance().initializeExtensions();
}
setInitialized(true);
};
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Test Failures Introduced</b></div>
<div id="fix">
This change removes try-catch and logging that existing tests in
ExtensionsStartup.test.tsx verify, causing test failures. While
ExtensionsLoader.initializeExtensions handles errors internally and logs
appropriately, the tests expect the logging to occur in ExtensionsStartup.
Update tests to match the new behavior or revert if logging is required here.
</div>
</div>
<small><i>Code Review Run #2c4cf8</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
