bito-code-review[bot] commented on PR #40134: URL: https://github.com/apache/superset/pull/40134#issuecomment-4455729913
<!-- Bito Reply --> The flagged issue is correct: replacing the placeholder revision ID 'a1b2c3d4e5f6' with '41292324bf4e' breaks upgrade continuity for databases already stamped with the old ID, as Alembic won't find the old revision. To resolve, create a no-op legacy migration with revision 'a1b2c3d4e5f6' and update the down_revision in the '41292324bf4e' file to reference it, maintaining the chain. There are no other comments on this PR. **superset/migrations/versions/2026-03-02_12-00_a1b2c3d4e5f6_add_granular_export_permissions.py** ``` # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. """add granular export permissions Revision ID: a1b2c3d4e5f6 Revises: 4b2a8c9d3e1f Create Date: 2026-03-02 12:00:00.000000 """ from alembic import op # noqa: E402 # revision identifiers, used by Alembic. revision = "a1b2c3d4e5f6" down_revision = "4b2a8c9d3e1f" def upgrade(): pass def downgrade(): pass ``` **superset/migrations/versions/2026-03-02_12-00_41292324bf4e_add_granular_export_permissions.py** ``` down_revision = "a1b2c3d4e5f6" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
