betodealmeida commented on PR #40134: URL: https://github.com/apache/superset/pull/40134#issuecomment-4473840395
This looks good, but I wouldn't merge it — there's nothing wrong with using `a1b2c3d4e5f6`, it's a valid revision (in fact, any string is a valid revision), and I don't see any benefit in changing — on the contrary, it might break things for deployments currently in that revision when they try to upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
