codeant-ai-for-open-source[bot] commented on code in PR #40136:
URL: https://github.com/apache/superset/pull/40136#discussion_r3245188450
##########
tests/unit_tests/commands/dashboard/export_test.py:
##########
@@ -188,6 +188,71 @@ def
test_file_content_null_chart_customization_config_does_not_raise():
assert result["metadata"]["chart_customization_config"] is None
+def test_file_content_includes_roles_for_dashboard_with_role_restrictions():
+ """
+ Regression guard for #21000: dashboards restricted via DASHBOARD_RBAC must
+ have their role assignments included in the exported YAML. Without this,
+ importing the bundle into another environment recreates the dashboard with
+ no role restriction — silently turning a restricted dashboard into a
+ publicly accessible one.
+
+ The export bundle is the canonical source of truth for migrating
+ dashboards across environments; dropping roles silently is a security
+ regression (a "least privilege" dashboard becomes "all privileges" on
+ import). The user, not the export pipeline, should decide whether to
+ strip roles before sharing a bundle.
+
+ We assert against role *names* rather than IDs because role IDs are
+ environment-local; the import side resolves names back to the destination
+ environment's roles.
+ """
+ from superset.commands.dashboard.export import ExportDashboardsCommand
+
+ role_alpha = MagicMock()
+ role_alpha.name = "Finance"
+ role_beta = MagicMock()
+ role_beta.name = "Executives"
+
+ mock_dashboard = _make_mock_dashboard({"native_filter_configuration": []})
+ mock_dashboard.roles = [role_alpha, role_beta]
+
+ with patch(
+
"superset.commands.dashboard.export.feature_flag_manager.is_feature_enabled",
+ return_value=False,
+ ):
+ content = ExportDashboardsCommand._file_content(mock_dashboard)
+
+ result = yaml.safe_load(content)
+ assert "roles" in result, (
+ "Dashboard export must include role names; without them, importing "
+ "into a fresh environment loses the role-based access restriction "
+ "and the dashboard becomes accessible to all roles by default."
+ )
+ assert sorted(result["roles"]) == ["Executives", "Finance"]
+
+
+def test_file_content_omits_roles_field_when_dashboard_has_no_roles():
+ """
+ A dashboard with no role restrictions must not emit an empty ``roles: []``
+ key. Older bundles in the wild were written without the key at all, and
+ the import side treats "missing" as "no restriction"; emitting an empty
+ list could trip importers that distinguish the two states.
+ """
+ from superset.commands.dashboard.export import ExportDashboardsCommand
+
+ mock_dashboard = _make_mock_dashboard({"native_filter_configuration": []})
+ mock_dashboard.roles = []
+
+ with patch(
+
"superset.commands.dashboard.export.feature_flag_manager.is_feature_enabled",
+ return_value=False,
+ ):
+ content = ExportDashboardsCommand._file_content(mock_dashboard)
+
+ result = yaml.safe_load(content)
+ assert "roles" not in result or result["roles"] == []
Review Comment:
**🟠 Architect Review — HIGH**
The regression test for dashboards with no role restrictions contradicts its
own docstring: it allows both a missing `roles` field and `roles: []`, so a
change that emits an empty roles list would pass the test while violating the
stated "must not emit empty roles" requirement and failing to guard the
intended backward-compatibility behavior.
**Suggestion:** Make the assertion strict (for example `assert "roles" not
in result`) so that dashboards with no roles never export a `roles` key; if
`roles: []` is intentionally supported, add a separate explicit test
documenting that behavior.
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20an%20%2A%2AArchitect%20%2F%20Logical%20Review%2A%2A%20comment%20left%20during%20a%20code%20review.%20These%20reviews%20are%20first-class%2C%20important%20findings%20%E2%80%94%20not%20optional%20suggestions.%20Do%20NOT%20dismiss%20this%20as%20a%20%27big%20architectural%20change%27%20just%20because%20the%20title%20says%20architect%20review%3B%20most%20of%20these%20can%20be%20resolved%20with%20a%20small%2C%20localized%20fix%20once%20the%20intent%20is%20understood.%0A%0A%2A%2APath%3A%2A%2A%20tests%2Funit_tests%2Fcommands%2Fdashboard%2Fexport_test.py%0A%2A%2ALine%3A%2A%2A%20234%3A253%0A%2A%2AComment%3A%2A%2A%0A%09%2AHIGH%3A%20The%20regression%20test%20for%20dashboards%20with%20no%20role%20restrictions%20contradicts%20its%20own%20docstring%3A%20it%20allows%20both%20a%20missing%20%60roles%60%20field%20and%20%60roles%3A%20%5B%5D%60%2C%20so%20a%20change%20that%20emits%20an%20empty%20roles%20list%20would%20pass
%20the%20test%20while%20violating%20the%20stated%20%22must%20not%20emit%20empty%20roles%22%20requirement%20and%20failing%20to%20guard%20the%20intended%20backward-compatibility%20behavior.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AIf%20a%20suggested%20approach%20is%20provided%20above%2C%20use%20it%20as%20the%20authoritative%20instruction.%20If%20no%20explicit%20code%20suggestion%20is%20given%2C%20you%20MUST%20still%20draft%20and%20apply%20your%20own%20minimal%2C%20localized%20fix%20%E2%80%94%20do%20not%20punt%20back%20with%20%27no%20suggestion%20provided%2C%20review%20manually%27.%20Keep%20the%20change%20as%20small%20as%20possible%3A%20add%20a%20guard%20clause%2C%20gate%20on%20a%20loading%20state%2C%20reorder%20an%20await%2C%20wrap%20in%20a%20conditional%2C%20etc.%20Do%20not%20refactor%20surrounding%20code%20or%20expand
%20scope%20beyond%20the%20finding.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20an%20%2A%2AArchitect%20%2F%20Logical%20Review%2A%2A%20comment%20left%20during%20a%20code%20review.%20These%20reviews%20are%20first-class%2C%20important%20findings%20%E2%80%94%20not%20optional%20suggestions.%20Do%20NOT%20dismiss%20this%20as%20a%20%27big%20architectural%20change%27%20just%20because%20the%20title%20says%20architect%20review%3B%20most%20of%20these%20can%20be%20resolved%20with%20a%20small%2C%20localized%20fix%20once%20the%20intent%20is%20understood.%0A%0A%2A%2APath%3A%2A%2A%20tests%2Funit_tests%2Fcommands%2Fdashboard
%2Fexport_test.py%0A%2A%2ALine%3A%2A%2A%20234%3A253%0A%2A%2AComment%3A%2A%2A%0A%09%2AHIGH%3A%20The%20regression%20test%20for%20dashboards%20with%20no%20role%20restrictions%20contradicts%20its%20own%20docstring%3A%20it%20allows%20both%20a%20missing%20%60roles%60%20field%20and%20%60roles%3A%20%5B%5D%60%2C%20so%20a%20change%20that%20emits%20an%20empty%20roles%20list%20would%20pass%20the%20test%20while%20violating%20the%20stated%20%22must%20not%20emit%20empty%20roles%22%20requirement%20and%20failing%20to%20guard%20the%20intended%20backward-compatibility%20behavior.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AIf%20a%20suggested%20approach%20is%20provided%20above%2C%20use%20it%20as%20the%20authoritative%20instruction.%20If%20no%20explicit%20code%20suggestion%20is%20given%2C%20you%20MUST%20still%20draft%20and%20apply%20your%20o
wn%20minimal%2C%20localized%20fix%20%E2%80%94%20do%20not%20punt%20back%20with%20%27no%20suggestion%20provided%2C%20review%20manually%27.%20Keep%20the%20change%20as%20small%20as%20possible%3A%20add%20a%20guard%20clause%2C%20gate%20on%20a%20loading%20state%2C%20reorder%20an%20await%2C%20wrap%20in%20a%20conditional%2C%20etc.%20Do%20not%20refactor%20surrounding%20code%20or%20expand%20scope%20beyond%20the%20finding.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is an **Architect / Logical Review** comment left during a code review.
These reviews are first-class, important findings — not optional suggestions.
Do NOT dismiss this as a 'big architectural change' just because the title says
architect review; most of these can be resolved with a small, localized fix
once the intent is understood.
**Path:** tests/unit_tests/commands/dashboard/export_test.py
**Line:** 234:253
**Comment:**
*HIGH: The regression test for dashboards with no role restrictions
contradicts its own docstring: it allows both a missing `roles` field and
`roles: []`, so a change that emits an empty roles list would pass the test
while violating the stated "must not emit empty roles" requirement and failing
to guard the intended backward-compatibility behavior.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
If a suggested approach is provided above, use it as the authoritative
instruction. If no explicit code suggestion is given, you MUST still draft and
apply your own minimal, localized fix — do not punt back with 'no suggestion
provided, review manually'. Keep the change as small as possible: add a guard
clause, gate on a loading state, reorder an await, wrap in a conditional, etc.
Do not refactor surrounding code or expand scope beyond the finding.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
