bito-code-review[bot] commented on PR #40136:
URL: https://github.com/apache/superset/pull/40136#issuecomment-4456003222
<!-- Bito Reply -->
The flagged issue is correct: the test's docstring states that dashboards
with no roles 'must not emit an empty roles key', but the assertion allows both
missing 'roles' and 'roles: []', contradicting the requirement. To resolve,
update the assertion to strictly check that 'roles' is not in the result,
ensuring no 'roles' key is emitted for unrestricted dashboards.
**tests/unit_tests/commands/dashboard/export_test.py**
```
result = yaml.safe_load(content)
assert "roles" not in result
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
