rusackas opened a new pull request, #40206:
URL: https://github.com/apache/superset/pull/40206

   ## Summary
   
   Coordinated bump of `jest` (30.3.0→30.4.2) and `jest-environment-jsdom` 
(29.7.0→30.4.1) in the main superset-frontend package, plus npm `overrides` to 
force jest internals (`jest-mock`, `jest-runtime`, `@jest/globals`, 
`@jest/types`, `jest-util`, `jest-circus`, `jest-environment-node`) to the 
matching 30.4.x line.
   
   Replaces dependabot PR #40089 which had to be closed.
   
   ### Why coordinated?
   
   jest 30.4 introduced `_moduleMocker.clearMocksOnScope()` in `jest-runtime`. 
A single-package bump of just `jest` failed because npm dedupes 
`[email protected]` from `[email protected]` and 
`@storybook/[email protected]`, leaving `[email protected]` calling a method 
that doesn't exist on the deduplicated `jest-mock`. The result was:
   
   ```
   TypeError: this._moduleMocker.clearMocksOnScope is not a function
     at Runtime.resetModules (node_modules/jest-runtime/build/index.js:3784:28)
   ```
   
   …across all 8 jest shards.
   
   ### Why @storybook/test-runner is not bumped
   
   No released version of `@storybook/test-runner` is compatible with both 
storybook 8.x and jest 30.x. The maintainers added jest 30 support only after 
dropping storybook 8 support (0.24.x requires storybook ≥10). The `overrides` 
block forces `@storybook/test-runner`'s transitive jest deps to 30.4 — verified 
locally by running `src/views/CRUD/hooks.test.tsx` (one of the failing files on 
the dependabot PR): 30/30 tests pass.
   
   ## Test plan
   
   - [x] `npm ci` succeeds (lockfile in sync)
   - [x] Local run of a previously-failing test file passes 
(`src/views/CRUD/hooks.test.tsx`)
   - [ ] Full CI matrix passes
   - [ ] @storybook/test-runner still works (probably tested via test-storybook 
job in CI)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to