hainenber commented on code in PR #40206:
URL: https://github.com/apache/superset/pull/40206#discussion_r3260054998


##########
superset-frontend/package.json:
##########
@@ -412,7 +412,14 @@
     "@luma.gl/gltf": "~9.2.5",
     "@luma.gl/shadertools": "~9.2.5",
     "@luma.gl/webgl": "~9.2.5",
-    "fast-xml-parser": "^5.8.0"
+    "fast-xml-parser": "^5.8.0",

Review Comment:
   I'm not sure if having these transitive deps added directly is idiomatic 
here. IMO, we can tolerate a bit of duplication to ensure a more streamlined 
dep graph for both human and machine readability



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to