rusackas commented on PR #39330: URL: https://github.com/apache/superset/pull/39330#issuecomment-4488605962
@villebro @michael-s-molina @sadpandajoe @sfirke This PR changes the output of the built-in DURATION number formatter: values like 10500ms previously rendered as 10.5s (via pretty-ms) and now render as 10s by default (via Intl.DurationFormat, which omits sub-second fields unless formatSubMilliseconds: true is set). It's noted in UPDATING.md, so I'm OK with this... but if anyone wants to block this for a major version please do so.. it just seems a little small for that to me :D Aproving, but won't merge until there's a second stamp. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
