bito-code-review[bot] commented on code in PR #39330: URL: https://github.com/apache/superset/pull/39330#discussion_r3270822312
########## superset/translations/ru/LC_MESSAGES/messages.po: ########## @@ -5122,16 +5122,16 @@ msgid "Duration Ms" msgstr "Продолжительность (мс)" msgid "Duration in ms (1.40008 => 1ms 400µs 80ns)" -msgstr "Продолжительность в мс (1.40008 => 1ms 400µs 80ns)" +msgstr "Продолжительность в мс (1.40008 => 1 мс 400 мкс 80 нс)" msgid "Duration in ms (100.40008 => 100ms 400µs 80ns)" -msgstr "Продолжительность в мс (100.40008 => 100ms 400µs 80ns)" +msgstr "Продолжительность в мс (100.40008 => 100 мс 400 мкс 80 нс)" -msgid "Duration in ms (10500 => 0:10.5)" -msgstr "Продолжительность в мс (10500 => 0:10.5)" +msgid "Duration in ms (10500 => 0:00:10.5)" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation msgid modified incorrectly</b></div> <div id="fix"> The msgid on line 5130 was changed from `Duration in ms (10500 => 0:10.5)` to `Duration in ms (10500 => 0:00:10.5)`, but the English source file still contains the original msgid. This breaks gettext translation lookup — the msgstr will not be returned for the original msgid, effectively dropping the Russian translation for this string. Only msgstr values should be modified in translation files; msgid values must match the source language exactly. </div> </div> <small><i>Code Review Run #baa734</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
