bito-code-review[bot] commented on code in PR #40274:
URL: https://github.com/apache/superset/pull/40274#discussion_r3270233018
##########
pytest.ini:
##########
@@ -18,5 +18,30 @@
testpaths =
tests
python_files = *_test.py test_*.py *_tests.py *viz/utils.py
-addopts = -p no:warnings
+# `-p no:warnings` temporarily disabled in favor of more finely tuned
`filterwarnings`.
+#addopts = -p no:warnings
asyncio_mode = auto
+
+# `ignore` virtually reproduces to `-p no:warnings`.
+# Always print RemovedIn20Warning when SQLALCHEMY_WARN_20=1.
Review Comment:
<!-- Bito Reply -->
The suggestion in the PR comment is valid and should be applied. The
`ignore` filter on line 29 will override the `always` filter on line 30, making
the latter ineffective. The suggested fix rearranges the filters to ensure
`always` is applied before `ignore`, aligning with the intended behavior
described in the comment on line 26.
**pytest.ini**
```
28: filterwarnings =
29: ignore
30: always::sqlalchemy.exc.RemovedIn20Warning
```
**pytest.ini**
```
28: filterwarnings =
29: always::sqlalchemy.exc.RemovedIn20Warning
30: ignore
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
