bito-code-review[bot] commented on PR #40288: URL: https://github.com/apache/superset/pull/40288#issuecomment-4496582308
<!-- Bito Reply --> The PR comment indicates a logic error where the `name` query parameter is being set directly from `request.title` without validation. This can lead to SQL Lab tabs with blank titles if the input is whitespace-only. To fix this, we should normalize the `request.title` value by stripping whitespace and ensuring it's non-empty before assigning it to the `name` parameter. This will prevent the creation of tabs with blank titles and align with SQL Lab's normal untitled naming behavior. **superset/mcp_service/sql_lab/tool/open_sql_lab_with_context.py** ``` params["name"] = request.title.strip() if request.title else None ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
