hainenber commented on PR #39443:
URL: https://github.com/apache/superset/pull/39443#issuecomment-4503997815
@rusackas there's one small security issue that `zizmor` found out but the
rest is LGTM for me :D
```diff
if: steps.check.outputs.python == 'true' ||
steps.check.outputs.frontend == 'true'
run: |
# For PRs use the base branch; for direct pushes compare against
the previous commit.
- BASE_REF="${{ github.event.pull_request.base.ref }}"
+ BASE_REF="${GITHUB_EVENT_PULL_REQUEST_BASE_REF}"
if [ -n "$BASE_REF" ]; then
git fetch --depth=1 origin "$BASE_REF"
else
- git fetch --depth=2 origin "${{ github.ref }}"
+ git fetch --depth=2 origin "${GITHUB_REF}"
fi
git worktree add /tmp/base-worktree FETCH_HEAD
+ env:
+ GITHUB_EVENT_PULL_REQUEST_BASE_REF: ${{
github.event.pull_request.base.ref }}
# Run babel_update against BASE source + BASE translations. Any drift
# already present on the base branch (source strings that have changed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
