rusackas commented on code in PR #40237: URL: https://github.com/apache/superset/pull/40237#discussion_r3305383585
########## superset/models/core.py: ########## @@ -1343,6 +1379,30 @@ def execute_async( sqla.event.listen(Database, "after_delete", security_manager.database_after_delete) +def _evict_engine_cache( + mapper: Any, # noqa: ANN401 + connection: Any, # noqa: ANN401 Review Comment: Good catch — fixed in ac3a440ab5. Added `Mapper` to the `sqlalchemy.orm` import and replaced both `Any` annotations with `Mapper` / `Connection`, matching the `database_after_update`/`database_after_delete` signatures in `security/manager.py`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
