bito-code-review[bot] commented on code in PR #40237: URL: https://github.com/apache/superset/pull/40237#discussion_r3305385259
########## superset/models/core.py: ########## @@ -1343,6 +1379,30 @@ def execute_async( sqla.event.listen(Database, "after_delete", security_manager.database_after_delete) +def _evict_engine_cache( + mapper: Any, # noqa: ANN401 + connection: Any, # noqa: ANN401 Review Comment: <!-- Bito Reply --> The suggestion to replace `Any` with `Mapper` and `Connection` in the `_evict_engine_cache` function is valid and appropriate. It aligns with the project's type-hinting standards and improves code clarity and correctness. The change ensures that the function's parameters are properly typed, matching the usage in other parts of the codebase like `database_after_update` and `database_after_delete`. This makes the function safer and easier to understand for future maintainers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
