aminghadersohi commented on PR #39922: URL: https://github.com/apache/superset/pull/39922#issuecomment-4556294001
One item from fitzee's review I didn't address explicitly in prior replies: **LOW — `configure()` startup ordering window**: If a module imports `get_registry()` at module scope before `configure_mcp_chart_registry()` runs in `initialization/__init__.py`, the first call sees the default unconfigured `_filter_config`. This is intentionally deferred — with an empty default config (`disabled_plugins=frozenset()`, `enabled_func=None`) the window is benign in practice because all plugins are visible by default. A non-empty `MCP_DISABLED_CHART_PLUGINS` list has a brief window where it doesn't apply, but this is startup-sequencing rather than a correctness bug. Fixing it would require a more invasive startup-ordering change that goes beyond this PR's scope. Logging a warning if `configure()` is called after the first `get()` would be a reasonable follow-up. All four blocking items and the MEDIUM/NIT non-blocking items are addressed in `0b6b98dcf7`. CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
