aminghadersohi commented on PR #40346: URL: https://github.com/apache/superset/pull/40346#issuecomment-4566118477
Applied cross-PR feedback from richardfogaca's thorough reviews on #40344 and #40348, same patterns addressed here where applicable. **What was applied:** **columns_available derivation (from #40348 fix):** Changed `list_queries` and `list_saved_queries` to use `list(QueryInfo.model_fields.keys())` / `list(SavedQueryInfo.model_fields.keys())` as the `columns_available` source, rather than the manually maintained `ALL_QUERY_COLUMNS` / `ALL_SAVED_QUERY_COLUMNS` constants. This ensures advertised columns always exactly match what the response schema serializes, preventing future drift — the same fix applied to `list_reports` in #40348. **What was analyzed but not applicable:** - **Feature/config guards** (from #40344): No equivalent config flags (`SUPERSET_LOG_VIEW`, `GLOBAL_TASK_FRAMEWORK`) exist for SQL query history or saved queries — these are always-on SQL Lab features. No guard needed. - **datetime filter type normalization** (from #40344): The `start_time` field added to `QueryFilter.col` is a `Numeric(precision=20, scale=6)` epoch-seconds column, not a `DateTime` column, so there is no datetime-vs-VARCHAR bind type mismatch. Numeric float comparisons are correct as-is. - **get_schema filter mismatch** (from #40348): `get_schema` does not support `model_type="query"` or `"saved_query"` yet, so there is no schema-discovery/filter-whitelist divergence to fix. - **Default instructions**: Already present — `list_queries`, `get_query_info`, `list_saved_queries`, and `get_saved_query_info` are all listed in the SQL Lab Integration section of `get_default_instructions()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
