bito-code-review[bot] commented on code in PR #40507: URL: https://github.com/apache/superset/pull/40507#discussion_r3320108838
########## helm/superset/values.yaml: ########## @@ -729,6 +729,119 @@ supersetWebsockets: # -- Set priorityClassName for supersetWebsockets pods priorityClassName: ~ + +supersetMcp: + # -- Enables the Superset MCP Server, exposed by default via the ingress /mcp subpath + # WARNING: this requires fastMCP to be installed, which can be done by installing `apache-superset[fastmcp]` + enabled: false + replicaCount: 1 + # -- Sets the [pod disruption budget](https://kubernetes.io/docs/tasks/run-application/configure-pdb/) for supersetMcp pods + podDisruptionBudget: + # -- Whether the pod disruption budget should be created + enabled: false + # -- If set, maxUnavailable must not be set - see https://kubernetes.io/docs/tasks/run-application/configure-pdb/\#specifying-a-poddisruptionbudget + minAvailable: 1 + # -- If set, minAvailable must not be set - see https://kubernetes.io/docs/tasks/run-application/configure-pdb/\#specifying-a-poddisruptionbudget + maxUnavailable: 1 Review Comment: <div> <div id="suggestion"> <div id="issue"><b>K8s PDB Mutually Exclusive Fields</b></div> <div id="fix"> The `supersetMcp.podDisruptionBudget` block defines both `minAvailable: 1` and `maxUnavailable: 1` (lines 743-745). Kubernetes PDBs reject simultaneous specification of both fields per https://kubernetes.io/docs/tasks/run-application/configure-pdb/#specifying-a-poddisruptionbudget. This will cause `helm upgrade` failures when PDB is enabled. The supersetWebsockets PDB at line ~675 only has `minAvailable`. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- helm/superset/values.yaml +++ helm/superset/values.yaml @@ -741,9 +741,6 @@ supersetMcp: # -- If set, maxUnavailable must not be set - see https://kubernetes.io/docs/tasks/run-application/configure-pdb/\#specifying-a-poddisruptionbudget minAvailable: 1 - # -- If set, minAvailable must not be set - see https://kubernetes.io/docs/tasks/run-application/configure-pdb/\#specifying-a-poddisruptionbudget - maxUnavailable: 1 # -- Command ``` </div> </details> </div> <small><i>Code Review Run #bca8df</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
