bito-code-review[bot] commented on code in PR #40507: URL: https://github.com/apache/superset/pull/40507#discussion_r3323275136
########## helm/superset/values.yaml: ########## @@ -729,6 +729,119 @@ supersetWebsockets: # -- Set priorityClassName for supersetWebsockets pods priorityClassName: ~ + +supersetMcp: + # -- Enables the Superset MCP Server, exposed by default via the ingress /mcp subpath + # WARNING: this requires fastMCP to be installed, which can be done by installing `apache-superset[fastmcp]` + enabled: false + replicaCount: 1 + # -- Sets the [pod disruption budget](https://kubernetes.io/docs/tasks/run-application/configure-pdb/) for supersetMcp pods + podDisruptionBudget: + # -- Whether the pod disruption budget should be created + enabled: false + # -- If set, maxUnavailable must not be set - see https://kubernetes.io/docs/tasks/run-application/configure-pdb/\#specifying-a-poddisruptionbudget + minAvailable: 1 + # -- If set, minAvailable must not be set - see https://kubernetes.io/docs/tasks/run-application/configure-pdb/\#specifying-a-poddisruptionbudget + maxUnavailable: 1 Review Comment: <!-- Bito Reply --> The suggestion is valid and should be applied. The Kubernetes PodDisruptionBudget (PDB) specification requires that only one of `minAvailable` or `maxUnavailable` be set, not both. The current configuration violates this rule and will cause deployment failures. Removing the `maxUnavailable: 1` line aligns the PDB configuration with Kubernetes requirements and matches the pattern used in other PDB configurations in the file (like `supersetWebsockets`). **helm/superset/values.yaml** ``` - # -- If set, minAvailable must not be set - see https://kubernetes.io/docs/tasks/run-application/configure-pdb/ - maxUnavailable: 1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
