bito-code-review[bot] commented on code in PR #40358:
URL: https://github.com/apache/superset/pull/40358#discussion_r3327360343
##########
superset/commands/tag/update.py:
##########
@@ -31,10 +31,11 @@
class UpdateTagCommand(UpdateMixin, BaseCommand):
- def __init__(self, model_id: int, data: dict[str, Any]):
+ def __init__(self, model_id: int, data: dict[str, Any], bulk_create: bool
= False):
self._model_id = model_id
self._properties = data.copy()
self._model: Optional[Tag] = None
+ self._bulk_create = bulk_create
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Test Coverage</b></div>
<div id="fix">
The `bulk_create` parameter is added but existing unit tests in
`tests/unit_tests/tags/commands/update_test.py` do not test this parameter
directly. Tests only verify basic update behavior without testing
concurrency-safe vs destructive modes.
</div>
</div>
<small><i>Code Review Run #dbe4b3</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
