aminghadersohi commented on code in PR #40358:
URL: https://github.com/apache/superset/pull/40358#discussion_r3328070233
##########
superset/commands/tag/update.py:
##########
@@ -31,10 +31,11 @@
class UpdateTagCommand(UpdateMixin, BaseCommand):
- def __init__(self, model_id: int, data: dict[str, Any]):
+ def __init__(self, model_id: int, data: dict[str, Any], bulk_create: bool
= False):
self._model_id = model_id
self._properties = data.copy()
self._model: Optional[Tag] = None
+ self._bulk_create = bulk_create
Review Comment:
Fixed: added to . The new test verifies that passing to preserves
pre-existing relationships that are not in the list — directly covering the
non-destructive mode added to the command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
