rusackas opened a new pull request, #40544:
URL: https://github.com/apache/superset/pull/40544
### SUMMARY
This is a re-open of #28038 (adopted from the original author @mtrentz). The
original PR's branch was in a fork (`mtrentz/superset`) whose CI was never
approved to run, leaving the PR stuck indefinitely. Moving the branch to
`apache/superset` directly so CI runs.
**The fix:** BigNumber visualization didn't apply color formatters when the
value was exactly `0`, because `if (bigNumber)` is falsy for zero. Changed to
`if (bigNumber !== null && bigNumber !== undefined)`.
The test file used a top-level `function` declaration which caused TS2393
("duplicate function implementation") in TypeScript's global-script mode.
Changed to a `const` arrow function to avoid the issue.
Closes #28038
### TESTING INSTRUCTIONS
```bash
cd superset-frontend
npm test -- plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.test.tsx
```
### ADDITIONAL INFORMATION
- [x] Has associated issue: closes #28038
- [ ] Required feature flags
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
