codeant-ai-for-open-source[bot] commented on code in PR #40544:
URL: https://github.com/apache/superset/pull/40544#discussion_r3328214464
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -204,11 +204,8 @@ function BigNumberVis({
let numberColor;
if (hasThresholdColorFormatter) {
colorThresholdFormatters!.forEach(formatter => {
- const formatterResult = bigNumber
- ? formatter.getColorFromValue(bigNumber as number)
- : false;
- if (formatterResult) {
- numberColor = formatterResult;
+ if (typeof bigNumber === 'number' && !isNaN(bigNumber)) {
+ numberColor = formatter.getColorFromValue(bigNumber);
}
Review Comment:
**🟠Architect Review — HIGH**
The updated renderHeader loop assigns numberColor on every formatter call
without checking the return value, so when multiple conditional-format rules
are configured, a later formatter that returns undefined will overwrite a
previously matched color and clear the applied threshold color.
**Suggestion:** Preserve the previous semantics by only updating numberColor
when formatter.getColorFromValue(bigNumber) returns a truthy value, e.g.
compute formatterResult inside the numeric-type check and guard the assignment,
so that 0 still passes the numeric check but non-matching rules do not
overwrite an earlier matched color.
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=16d7a7ba50fe48048afdb333fa89b297&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=16d7a7ba50fe48048afdb333fa89b297&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is an **Architect / Logical Review** comment left during a code review.
These reviews are first-class, important findings — not optional suggestions.
Do NOT dismiss this as a 'big architectural change' just because the title says
architect review; most of these can be resolved with a small, localized fix
once the intent is understood.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx
**Line:** 206:209
**Comment:**
*HIGH: The updated renderHeader loop assigns numberColor on every
formatter call without checking the return value, so when multiple
conditional-format rules are configured, a later formatter that returns
undefined will overwrite a previously matched color and clear the applied
threshold color.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
If a suggested approach is provided above, use it as the authoritative
instruction. If no explicit code suggestion is given, you MUST still draft and
apply your own minimal, localized fix — do not punt back with 'no suggestion
provided, review manually'. Keep the change as small as possible: add a guard
clause, gate on a loading state, reorder an await, wrap in a conditional, etc.
Do not refactor surrounding code or expand scope beyond the finding.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
