rusackas commented on code in PR #40536:
URL: https://github.com/apache/superset/pull/40536#discussion_r3328330045
##########
superset/commands/chart/create.py:
##########
@@ -43,6 +44,11 @@ class CreateChartCommand(CreateMixin, BaseCommand):
def __init__(self, data: dict[str, Any]):
self._properties = data.copy()
+ if params_str := self._properties.get("params"):
+ params = json.loads(params_str)
Review Comment:
Standing by rusackas's assessment — the Marshmallow schema in
`superset/charts/schemas.py` applies `validate=utils.validate_json` to `params`
before this command is ever constructed, so `json.loads` here can only fail if
something bypasses the schema layer. Adding a try-except would be dead code
that obscures that invariant. Declining.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
