rusackas commented on code in PR #40536:
URL: https://github.com/apache/superset/pull/40536#discussion_r3329205794
##########
superset/commands/chart/create.py:
##########
@@ -43,6 +44,11 @@ class CreateChartCommand(CreateMixin, BaseCommand):
def __init__(self, data: dict[str, Any]):
self._properties = data.copy()
+ if params_str := self._properties.get("params"):
+ params = json.loads(params_str)
Review Comment:
The Marshmallow schema in `superset/charts/schemas.py` applies
`validate=utils.validate_json` to the `params` field before
`CreateChartCommand` is ever instantiated, so `json.loads(params_str)` here
cannot receive malformed JSON. Adding a redundant try-except would paper over a
schema bypass that cannot happen via the API layer. Thread closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
