bito-code-review[bot] commented on PR #40557: URL: https://github.com/apache/superset/pull/40557#issuecomment-4582388647
<!-- Bito Reply --> The PR comment indicates a security vulnerability in the Docker re-invocation within the `scripts/uv-pip-compile.sh` script. The use of `$*` in a `bash -c` string can lead to argument corruption and unintended command execution due to shell metacharacters. To resolve this, arguments should be passed without shell re-parsing to preserve their original boundaries. A suggested fix is to avoid interpolating `$*` into the command string and instead pass arguments directly to the container. **scripts/uv-pip-compile.sh** ``` docker run ... bash -c "pip install uv==0.11.17 && ./scripts/uv-pip-compile.sh $*" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
