sha174n commented on PR #40557: URL: https://github.com/apache/superset/pull/40557#issuecomment-4620749086
LGTM in shape, but one bug: `git commit --signoff "msg"` without `-m` is parsed as a pathspec, so this fails with `error: pathspec ... did not match any file(s) known to git`. Should be `git commit --signoff -m "..."`. The dep-review allow-list trim (`store2`, `node-forge`) checks out, neither is in the lockfile on current master. uv pin to 0.11.17 is fine too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
