rusackas commented on code in PR #40536:
URL: https://github.com/apache/superset/pull/40536#discussion_r3329564174
##########
superset/commands/chart/create.py:
##########
@@ -43,6 +44,11 @@ class CreateChartCommand(CreateMixin, BaseCommand):
def __init__(self, data: dict[str, Any]):
self._properties = data.copy()
+ if params_str := self._properties.get("params"):
+ params = json.loads(params_str)
Review Comment:
Agreed with the assessment here — the Marshmallow schema applies
`validate=utils.validate_json` to `params` before `CreateChartCommand` is ever
constructed, making `json.loads(params_str)` safe. Adding a try/except would be
dead code that masks schema bypass bugs rather than fixing them. Thread is
settled; this is a Bito loop artifact from `/resolve` not being supported on
inline comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
