rusackas commented on code in PR #40546:
URL: https://github.com/apache/superset/pull/40546#discussion_r3329610500
##########
superset-frontend/src/utils/navigationUtils.ts:
##########
@@ -25,9 +26,9 @@ export const navigateTo = (
if (options?.newWindow) {
window.open(ensureAppRoot(url), '_blank', 'noopener noreferrer');
} else if (options?.assign) {
- window.location.assign(ensureAppRoot(url));
+ window.location.assign(sanitizeUrl(ensureAppRoot(url)));
} else {
- window.location.href = ensureAppRoot(url);
+ window.location.href = sanitizeUrl(ensureAppRoot(url));
}
Review Comment:
Thread closed. The `sanitizeUrl` fix was applied — all three navigation
paths (`assign`, `href`, and `newWindow`) are consistently hardened. Bito's
subsequent replies are loop artifacts from `/resolve` not being supported on
inline comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
