bito-code-review[bot] commented on code in PR #40546:
URL: https://github.com/apache/superset/pull/40546#discussion_r3329713096
##########
superset-frontend/src/utils/navigationUtils.ts:
##########
@@ -25,9 +26,9 @@ export const navigateTo = (
if (options?.newWindow) {
window.open(ensureAppRoot(url), '_blank', 'noopener noreferrer');
} else if (options?.assign) {
- window.location.assign(ensureAppRoot(url));
+ window.location.assign(sanitizeUrl(ensureAppRoot(url)));
} else {
- window.location.href = ensureAppRoot(url);
+ window.location.href = sanitizeUrl(ensureAppRoot(url));
}
Review Comment:
<!-- Bito Reply -->
The thread in question has been resolved, and the fix for consistent
`sanitizeUrl` application across all navigation paths has been implemented.
Bito's repeated messages are a known artifact of the `/resolve` command not
being supported on inline comments, and no further action is needed. The code
now consistently applies `sanitizeUrl` to the `newWindow`, `assign`, and `href`
branches, ensuring predictable behavior for callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
