rusackas commented on code in PR #38170:
URL: https://github.com/apache/superset/pull/38170#discussion_r3330211460
##########
superset/charts/client_processing.py:
##########
@@ -389,7 +389,9 @@ def apply_client_processing( # noqa: C901
query["data"] = processed_df.to_dict()
elif query["result_format"] == ChartDataResultFormat.CSV:
buf = StringIO()
- processed_df.to_csv(buf, index=show_default_index)
+ # Apply CSV_EXPORT config for consistent CSV formatting
+ csv_export_config = current_app.config.get("CSV_EXPORT", {})
Review Comment:
Declining — the codebase already uses both patterns: direct
`config["CSV_EXPORT"]` (e.g., `viz.py:708`, `export.py:134`) and
`config.get("CSV_EXPORT", {})` (e.g., `charts/data/api.py:745`,
`sqllab/api.py:430`). The graceful-degradation form with `.get()` is
intentional on this new code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
