bito-code-review[bot] commented on code in PR #38170:
URL: https://github.com/apache/superset/pull/38170#discussion_r3330211795
##########
superset/charts/client_processing.py:
##########
@@ -389,7 +389,9 @@ def apply_client_processing( # noqa: C901
query["data"] = processed_df.to_dict()
elif query["result_format"] == ChartDataResultFormat.CSV:
buf = StringIO()
- processed_df.to_csv(buf, index=show_default_index)
+ # Apply CSV_EXPORT config for consistent CSV formatting
+ csv_export_config = current_app.config.get("CSV_EXPORT", {})
Review Comment:
<!-- Bito Reply -->
The suggestion to use direct dictionary access for `CSV_EXPORT` is valid in
this context. It aligns with the codebase's existing pattern and ensures
consistency. The change improves clarity by avoiding silent fallback behavior,
which is important for configuration values that should always be explicitly
defined.
**superset/charts/client_processing.py**
```
- csv_export_config = current_app.config.get("CSV_EXPORT", {})
+ csv_export_config = current_app.config["CSV_EXPORT"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
