rusackas commented on PR #40378: URL: https://github.com/apache/superset/pull/40378#issuecomment-4595646796
This PR only raised the `pyproject.toml` floor to `gevent>=26.4.0`; the lockfile (`requirements/development.txt`) still pinned `gevent==24.2.1`, so CI was resolving the **old** version — green CI here didn't actually exercise gevent 26. I regenerated the lockfile via `scripts/uv-pip-compile.sh` so the bump is real. Findings: - **gevent 26.4.0 requires `greenlet>=3.2.2`**, which conflicts with the pinned `greenlet==3.1.1` (uv: *no solution*). The regen lifts greenlet to **3.5.0** — the ceiling of the existing `greenlet>=3.0.3,<=3.5.0` constraint — kept in sync across `base.txt` and `development.txt`. Diff is exactly gevent + greenlet, no unrelated churn. - **gevent has no Python API usage in Superset** (no `import gevent` anywhere — it's only a gunicorn worker option), so there's no unit-test surface to add. ⚠️ The residual risk is (a) gevent worker runtime behavior and (b) the greenlet transitive bump (greenlet is SQLAlchemy's async bridge). Neither is covered by CI, so a **gevent gunicorn-worker smoke test** is recommended before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
