bito-code-review[bot] commented on code in PR #40588:
URL: https://github.com/apache/superset/pull/40588#discussion_r3337433619
##########
tests/unit_tests/commands/dashboard/export_test.py:
##########
@@ -256,6 +256,184 @@ def
test_file_content_omits_roles_field_when_dashboard_has_no_roles():
assert "roles" not in result
+def test_position_json_chart_id_leaks_env_local_integers():
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Regression test incomplete coverage</b></div>
<div id="fix">
This regression test does not cover the primary bug location in
`append_charts()` (export.py:94), which uses `chart.id` for chartId. The
current test mocks `model.slices = []`, bypassing the orphan-chart path
entirely. Add a test case with non-empty slices to validate that append_charts
strips/replaces chartId.
</div>
</div>
<small><i>Code Review Run #d64d59</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
