bito-code-review[bot] commented on code in PR #40588:
URL: https://github.com/apache/superset/pull/40588#discussion_r3337546878
##########
tests/unit_tests/commands/dashboard/export_test.py:
##########
@@ -256,6 +256,184 @@ def
test_file_content_omits_roles_field_when_dashboard_has_no_roles():
assert "roles" not in result
+def test_position_json_chart_id_leaks_env_local_integers():
Review Comment:
<!-- Bito Reply -->
The suggestion in the review comment is valid and addresses a legitimate
concern about test coverage. The current test does not cover the
`append_charts()` function's use of `chart.id`, which is the primary location
of the bug. Adding a test case with non-empty slices would ensure that the fix
for the `chartId` issue is properly validated. This suggestion should be
applied to improve the test's effectiveness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
