mikebridge commented on PR #40128: URL: https://github.com/apache/superset/pull/40128#issuecomment-4596992396
Thanks for the review. Follow-ups pushed in 3ce1b436f8: **Addressed:** - **Naive `datetime` in restore test** — added `tzinfo=timezone.utc` to all five `datetime(2026, 1, 1)` calls. The values stand in for `dashboard.deleted_at`, which is timezone-aware in production. - **DELETE response verification in partial-index test** — captured and asserted `response.status_code == 200` on the initial soft-delete. Makes the failure mode legible if the DELETE breaks rather than surfacing as a confusing downstream assertion. - **Dialect-gap docstring on `validate_slug_uniqueness`** — added notes to both `validate_slug_uniqueness` and `validate_update_slug_uniqueness` in `superset/daos/dashboard.py` explaining the SoftDeleteMixin auto-filter behaviour and the SQLite / MariaDB / MySQL<8 fallback gap. Cross-references the migration and `UPDATING.md`. - **Unused `logger` in `commands/dashboard/restore.py`** — removed the declaration and the `import logging`. The module followed a sibling-file pattern but the cargo was never exercised. **Skipped:** - **MySQL `DROP INDEX IF EXISTS`** — declining this one: `DROP INDEX IF EXISTS` inside `ALTER TABLE` is only valid on MySQL **8.0.29+**, but our branch gate (`_mysql_supports_functional_index`) accepts `>= 8.0` to cover functional-index support from 8.0.13. Adding the qualifier would break versions 8.0.13 through 8.0.28. The current code's implicit assumption that `idx_unique_slug` exists is well-founded — it was created in the 2015 migration `1a48a5411020` and has never been reverted in the upstream chain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
