mikebridge commented on PR #40128:
URL: https://github.com/apache/superset/pull/40128#issuecomment-4606615278
Thanks @bito-code-review — addressed in 6c56d5f390. The second
`self.client.delete(...)` now asserts `response.status_code == 200` with the
same error message shape as the first delete on line 420. A 500 on the second
delete will now fail the test at the source rather than surfacing later as a
count-mismatch assertion.
The filtered "missing visibility-filter bypass" suggestion on line 440 is a
deliberate choice — that test specifically validates the partial index lets
soft-deleted rows accumulate, and the
`execution_options(**{SKIP_VISIBILITY_FILTER_CLASSES: {Dashboard}})` bypass is
already on the count query at line 442-446. Adding it to other queries in the
test would conflate the two concerns. (Noting this for the record since the
rule filter may have hidden it from the actionable list.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
