bito-code-review[bot] commented on code in PR #40650:
URL: https://github.com/apache/superset/pull/40650#discussion_r3338273579
##########
superset/commands/security/create.py:
##########
@@ -50,5 +51,8 @@ def validate(self) -> None:
)
if len(tables) != len(self._tables):
raise DatasourceNotFoundValidationError()
+ for table in tables:
+ if not security_manager.can_access_datasource(datasource=table):
+ raise RLSDatasourceForbiddenError()
Review Comment:
<!-- Bito Reply -->
The suggestion is valid and worth considering for future refactoring.
Extracting the shared authorization logic into a helper function would reduce
duplication and improve maintainability. However, since this is out of scope
for the current security fix, it should be addressed in a follow-up refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
