rusackas commented on code in PR #40658:
URL: https://github.com/apache/superset/pull/40658#discussion_r3342367975
##########
superset/charts/data/api.py:
##########
@@ -617,6 +617,7 @@ def _extract_export_params_from_request(self) -> tuple[str
| None, int | None]:
"""Extract filename and expected_rows from request for streaming
exports."""
filename = request.form.get("filename")
if filename:
+ filename = secure_filename(filename) or None
Review Comment:
Thanks for confirming. Yes, the `or None` fallback is intentional so that
dangerous-only input collapses to a server-generated filename rather than an
empty `Content-Disposition`. No change needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
