rusackas commented on code in PR #40658: URL: https://github.com/apache/superset/pull/40658#discussion_r3347387031
########## superset/views/base.py: ########## @@ -141,7 +141,9 @@ def json_success(json_msg: str, status: int = 200) -> FlaskResponse: - return Response(json_msg, status=status, mimetype="application/json") + return Response( + json_msg, status=status, content_type="application/json; charset=utf-8" Review Comment: Confirmed: code-scanning finding 2461 tracks the stacktrace flow through get_error_msg() in views/base.py, which is gated behind the operator-controlled SHOW_STACKTRACE config flag and is unchanged by this PR. This PR only sets the charset on the json_success Response; it does not touch error/exception propagation. The finding predates this change and is out of scope here (operator-controlled deployment setting), so no code change is warranted in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
