semohr commented on code in PR #37396:
URL: https://github.com/apache/superset/pull/37396#discussion_r3348399786
##########
superset/utils/core.py:
##########
@@ -1813,6 +1813,42 @@ def extract_dataframe_dtypes(
return generic_types
+def extract_display_labels(
Review Comment:
This helper just forwards that logic to the already existing
`get_column_name` function (which as a side note is named wrong and should be
named `get_column_label` ).
As far as I can see that function does not handle that case. But the logic
here is quite convoluted so I might be missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
