bito-code-review[bot] commented on code in PR #37396:
URL: https://github.com/apache/superset/pull/37396#discussion_r3349743789
##########
superset-frontend/src/explore/components/DataTablesPane/components/useGridResultTable.tsx:
##########
@@ -69,7 +76,7 @@ export function useGridColumns(
};
})
: [],
- [colnames, data, coltypes, columnDisplayNames],
+ [colnames, data, coltypes, collabels],
);
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing unit tests for useGridColumns</b></div>
<div id="fix">
The `useGridColumns` function has no unit tests despite containing
refactored index-preservation logic and a new `collabels` parameter. Per rule
[6262], tests should verify the actual business logic — including the
map/filter/map chain, index alignment across `colnames`/`coltypes`/`collabels`,
and fallback when `collabels` is undefined or shorter than `colnames`.
</div>
</div>
<small><i>Code Review Run #e9dbd3</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
