mikebridge commented on PR #40129: URL: https://github.com/apache/superset/pull/40129#issuecomment-4614228208
Thanks @richardfogaca for the approval and the framing in the praise paragraph — the "guardrails the API diff alone wouldn't show" line is exactly the lens I had in mind when I structured the per-entity restore tests around owner / non-owner / no-can_write / trusted-loader paths. The architectural decisions you called out (mapping \`restore\` back to \`write\`, keeping restore on the shared command path, preserving chart relationships on soft-delete, the importer test matrix) all came directly from earlier-round review feedback — the iterative process did the work. Appreciate the careful trace through them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
