bito-code-review[bot] commented on code in PR #40129: URL: https://github.com/apache/superset/pull/40129#discussion_r3365403427
########## superset/translations/ja/LC_MESSAGES/messages.po: ########## @@ -2866,6 +2866,9 @@ msgstr "チャートの変更" msgid "Chart could not be created." msgstr "チャートを作成できませんでした。" +msgid "Chart could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Japanese translation</b></div> <div id="fix"> The `msgstr` for "Chart could not be restored." is empty. Japanese users will see the untranslated English error message when `ChartRestoreFailedError` is raised in `charts/api.py:640`. Following the pattern of adjacent translations (lines 2867, 2873), the translation should be "チャートを復元できませんでした。". </div> </div> <small><i>Code Review Run #1ed16d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/sk/LC_MESSAGES/messages.po: ########## @@ -3104,6 +3104,9 @@ msgstr "Zmeny grafu" msgid "Chart could not be created." msgstr "Graf sa nepodarilo vytvoriť." +msgid "Chart could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Slovak translation</b></div> <div id="fix"> The new translation entry `msgid "Chart could not be restored."` has an empty `msgstr ""`. Slovak users will see untranslated English text. Following the established pattern (created→vytvoriť, updated→aktualizovať), the translation should be `msgstr "Graf sa nepodarilo obnoviť."`. </div> </div> <small><i>Code Review Run #1ed16d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/lv/LC_MESSAGES/messages.po: ########## @@ -3072,6 +3072,9 @@ msgstr "Diagrammas izmaiņas" msgid "Chart could not be created." msgstr "Diagrammu nevarēja izveidot." +msgid "Chart could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing source template update</b></div> <div id="fix"> The source template `messages.pot` does not contain `msgid "Chart could not be restored."`, but the English translation file does. This translation was added directly without going through the standard i18n workflow. The source template must be regenerated first (`pybabel extract` + `pybabel update`) to ensure all language files receive this new string and the entry is properly tracked. </div> </div> <small><i>Code Review Run #1ed16d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/ko/LC_MESSAGES/messages.po: ########## @@ -2982,6 +2982,9 @@ msgstr "" msgid "Chart could not be created." msgstr "차트를 생성할 수 없습니다." +msgid "Chart could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Korean translation</b></div> <div id="fix"> The new translation string "Chart could not be restored." has an empty `msgstr`. Korean users will see the untranslated English text. Following the established pattern for similar messages in this file, the translation should be "차트를 복원할 수 없습니다.". </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/translations/ko/LC_MESSAGES/messages.po +++ superset/translations/ko/LC_MESSAGES/messages.po @@ -2983,7 +2983,7 @@ msgstr "차트를 생성할 수 없습니다." msgid "Chart could not be restored." -msgstr "" +msgstr "차트를 복원할 수 없습니다." msgid "Chart could not be updated." msgstr "차트를 업데이트할 수 없습니다." ``` </div> </details> </div> <small><i>Code Review Run #1ed16d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
