rusackas commented on code in PR #40084:
URL: https://github.com/apache/superset/pull/40084#discussion_r3352135635
##########
docker/docker-bootstrap.sh:
##########
@@ -96,7 +96,9 @@ case "${1}" in
echo " 🔒 Werkzeug debugger disabled (set SUPERSET_DEBUG_ENABLED=true
to enable)"
fi
- flask run -p $PORT --reload $DEBUGGER_FLAG --host=0.0.0.0
--exclude-patterns
"*/node_modules/*:*/.venv/*:*/build/*:*/__pycache__/*:*/superset-frontend/*"
+ flask run -p $PORT --reload $DEBUGGER_FLAG --host=0.0.0.0 \
+ --extra-files "/app/superset/extensions/.reload_trigger" \
+ --exclude-patterns
"*/node_modules/*:*/.venv/*:*/build/*:*/__pycache__/*:*/superset-frontend/*:*/superset/__init__.py"
Review Comment:
Thanks, but this one is based on a layout that does not exist here. The
`superset` package directory is bind-mounted in docker-compose as
`./superset:/app/superset`, so there is no double `superset/superset` nesting
inside the container. `local_extensions_watcher.py` resolves to
`/app/superset/extensions/local_extensions_watcher.py`, which makes
`Path(__file__).resolve().parent / ".reload_trigger"` equal to
`/app/superset/extensions/.reload_trigger` — exactly the path the bootstrap
script passes to `--extra-files`. For the same reason, `__init__.py` lives at
`/app/superset/__init__.py`, so the `*/superset/__init__.py` exclude pattern
matches it correctly. No path mismatch here, so no change needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
