bito-code-review[bot] commented on code in PR #40084:
URL: https://github.com/apache/superset/pull/40084#discussion_r3352136630
##########
docker/docker-bootstrap.sh:
##########
@@ -96,7 +96,9 @@ case "${1}" in
echo " 🔒 Werkzeug debugger disabled (set SUPERSET_DEBUG_ENABLED=true
to enable)"
fi
- flask run -p $PORT --reload $DEBUGGER_FLAG --host=0.0.0.0
--exclude-patterns
"*/node_modules/*:*/.venv/*:*/build/*:*/__pycache__/*:*/superset-frontend/*"
+ flask run -p $PORT --reload $DEBUGGER_FLAG --host=0.0.0.0 \
+ --extra-files "/app/superset/extensions/.reload_trigger" \
+ --exclude-patterns
"*/node_modules/*:*/.venv/*:*/build/*:*/__pycache__/*:*/superset-frontend/*:*/superset/__init__.py"
Review Comment:
<!-- Bito Reply -->
Your assessment of the path resolution is correct. Since the directory is
bind-mounted as `./superset:/app/superset`, the path
`/app/superset/extensions/.reload_trigger` correctly points to the trigger
file, and the exclude pattern `*/superset/__init__.py` correctly matches the
file at `/app/superset/__init__.py`. The suggestion provided by the reviewer is
based on a different directory structure and is not applicable here.
**docker/docker-bootstrap.sh**
```
flask run -p $PORT --reload $DEBUGGER_FLAG --host=0.0.0.0 \
--extra-files "/app/superset/extensions/.reload_trigger" \
--exclude-patterns
"*/node_modules/*:*/.venv/*:*/build/*:*/__pycache__/*:*/superset-frontend/*:*/superset/__init__.py"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
