bito-code-review[bot] commented on code in PR #40764: URL: https://github.com/apache/superset/pull/40764#discussion_r3357967829
########## superset/translations/sl/LC_MESSAGES/messages.po: ########## @@ -1830,7 +1833,7 @@ msgstr "Pri pridobivanju vrednosti shem je prišlo do napake: %s" msgid "An error occurred while fetching semantic layer types" msgstr "Pri pridobivanju CSS predlog je prišlo do napake" -#, fuzzy, python-format +#, fuzzy msgid "An error occurred while fetching semantic layers" msgstr "Pri pridobivanju vrednosti shem je prišlo do napake: %s" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect fuzzy flag removal</b></div> <div id="fix"> The `#, fuzzy` flag was removed from `An error occurred while fetching semantic layer types` (line 1833) and `An error occurred while fetching semantic layers` (line 1837), but their current translations incorrectly reference 'CSS predlog' (CSS templates) and 'shem' (schemas) instead of semantic layer terminology. Without the fuzzy flag, these incorrect translations will be used. The `#, fuzzy` flag should be restored until translations are corrected. </div> </div> <small><i>Code Review Run #2d3442</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -1240,6 +1240,9 @@ msgstr "Ajouter un nouveau formateur de couleur" msgid "Add new formatter" msgstr "Ajouter un nouveau formateur" +msgid "Add numbered column" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Untranslated entry added</b></div> <div id="fix"> New translation entry added with empty msgstr. This leaves the string untranslated for French users, showing English text in the UI. </div> </div> <small><i>Code Review Run #2d3442</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -4245,6 +4248,12 @@ msgstr "" "Les mesures SQL ponctuelles personnalisées ne sont pas activées pour cet " "ensemble de données" +msgid "Custom SQL fields cannot be parsed as a single SQL statement." +msgstr "" + +msgid "Custom SQL fields cannot contain set operations." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Untranslated entries added</b></div> <div id="fix"> Two new translation entries added with empty msgstr: 'Custom SQL fields cannot be parsed as a single SQL statement.' and 'Custom SQL fields cannot contain set operations.' These leave error messages untranslated for French users. </div> </div> <small><i>Code Review Run #2d3442</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -4194,6 +4197,12 @@ msgstr "自定義 SQL" msgid "Custom SQL ad-hoc metrics are not enabled for this dataset" msgstr "此數據集無法啟用自定義 SQL 即席查詢、" +msgid "Custom SQL fields cannot be parsed as a single SQL statement." +msgstr "" + +msgid "Custom SQL fields cannot contain set operations." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing translations for SQL error messages</b></div> <div id="fix"> Three new translation strings for Custom SQL validation errors added with empty msgstr values. These strings are used in `superset/connectors/sqla/models.py:928` for SQL validation errors. All three need Chinese translations per adaptive rule [6516]. </div> </div> <small><i>Code Review Run #2d3442</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt/LC_MESSAGES/messages.po: ########## @@ -1819,7 +1822,7 @@ msgstr "Ocorreu um erro ao criar a origem dos dados" msgid "An error occurred while pruning logs " msgstr "Ocorreu um erro ao renderizar a visualização: %s" -#, fuzzy, python-format +#, fuzzy msgid "An error occurred while refreshing the configuration schema" msgstr "Ocorreu um erro ao renderizar a visualização: %s" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Format flag removed incorrectly</b></div> <div id="fix"> The `python-format` flag was removed from 'An error occurred while pruning logs' but msgstr still shows 'Ocorreu um erro ao renderizar a visualização: %s' (copy-paste from a different message). Source code in scheduler.py shows it uses %s for exception, so format flag should be restored. </div> </div> <small><i>Code Review Run #2d3442</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/uk/LC_MESSAGES/messages.po: ########## @@ -1855,7 +1858,7 @@ msgstr "Не вдалося розібрати ключ." msgid "An error occurred while pruning logs " msgstr "Не вдалося очистити журнали " -#, fuzzy, python-format +#, fuzzy msgid "An error occurred while refreshing the configuration schema" msgstr "Не вдалося відтворити візуалізацію: %s" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>python-format flag missing</b></div> <div id="fix"> The `python-format` flag was removed from `msgid "An error occurred while refreshing the configuration schema"` but the msgstr still contains `%s`. Without this flag, the literal text `%s` will be displayed to users instead of the substituted error details. Restore the `python-format` flag. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/translations/uk/LC_MESSAGES/messages.po +++ b/superset/translations/uk/LC_MESSAGES/messages.po @@ -1858,7 +1858,7 @@ msgstr "Не вдалося очистити журнали " #, fuzzy msgid "An error occurred while refreshing the configuration schema" -msgstr "Не вдалося відтворити візуалізацію: %s" +msgstr "Не вдалося відтворити візуалізацію: %s" #, fuzzy, python-format msgstr "Не вдалося відтворити візуалізацію: %s" ``` </div> </details> </div> <small><i>Code Review Run #2d3442</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -11517,6 +11535,12 @@ msgstr "SQL" msgid "SQL Lab" msgstr "SQL Lab" +msgid "" +"SQL Lab cannot authorise a statement that could not be fully parsed. " +"Qualify tables explicitly and avoid dynamic SQL inside stored-procedure " +"or vendor-specific calls." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Untranslated entry added</b></div> <div id="fix"> New multi-line translation entry added with empty msgstr. This leaves a detailed SQL Lab error message untranslated for French users, which could hinder debugging. </div> </div> <small><i>Code Review Run #2d3442</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -1176,6 +1176,9 @@ msgstr "增加新的的顏色格式化器" msgid "Add new formatter" msgstr "新增格式化" +msgid "Add numbered column" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Chinese translation for new string</b></div> <div id="fix"> New translation string 'Add numbered column' at line 1179 is used in `plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx:504` but has no Chinese translation (msgstr is empty). Per adaptive rule [6516], all user-facing strings should be properly translated. </div> </div> <small><i>Code Review Run #2d3442</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -10541,6 +10553,12 @@ msgstr "過時" msgid "Proportional" msgstr "比例" +msgid "Public and privately shared sheets" +msgstr "" + +msgid "Publicly shared sheets only" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing translations for sheet sharing options</b></div> <div id="fix"> Two new translation strings for sheet sharing options added at lines 10556 and 10559 with empty msgstr values. These are used in `EncryptedField.tsx:133` for database connection form options. Both require Chinese translations per adaptive rule [6516]. </div> </div> <small><i>Code Review Run #2d3442</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -9492,6 +9501,9 @@ msgstr "未定義" msgid "Not equal to (≠)" msgstr "不等於（≠）" +msgid "Not found" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing translation for 'Not found' string</b></div> <div id="fix"> New translation string 'Not found' added at line 9504 without Chinese translation. This string is used in database connection form (`EncryptedField.tsx:133`). Requires translation per adaptive rule [6516]. </div> </div> <small><i>Code Review Run #2d3442</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
