EnxDev commented on PR #40764: URL: https://github.com/apache/superset/pull/40764#issuecomment-4634979205
> OK with me, but should we just pin 2.18.0 to make it easier? Would it make sense to keep the revert to 2.17.0 for now? My concern is that pinning to 2.18.0 is a broader and potentially riskier change, since it turns a translation fix into a dependency upgrade that affects the compiled requirements/*.txt lock files as well as superset/translations/requirements.txt, which may warrant additional review. Since the 2.18.0-generated files were the anomaly, reverting them seems like the smallest change to address the issue. If we decide to move to 2.18.0, would it be better to handle that in a separate PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
